Future dated post error « Neurotic Forums

Neurotic Forums » Neurotic Plugins » Organize Series WordPress Plugin » Bug Reports

Future dated post error

(16 posts) (5 voices)

Started 3 years ago by
Latest reply from Darren
This topic is not resolved

Tags:

Anonymous
Unregistered

Hi, was just testing the plugin, see what it can do and i noticed that in WP2.5.1 future dated posts that are added to a series undo themselves from the series when they publish themselves at the set time/date. They show in the TOC on single post prior to their publication date but return the default error page if trying to view it by clicking the link. It shows up if logged in.

Are these odd quirks with my particular set up, default theme, 2.5.1 and latest version of the plugin, or quirks generally?

Posted 3 years ago #
Darren
Neurotic Guy

That's a bug (if I can reproduce it) - I'll take a look at it sometime in the next few days and get it fixed :) Thanks for reporting it.

A couple of questions:

1. Does the future dated post show up in the post-list toc (on the single post page) when logged out? (it shouldn't)

Also, a quirk (but necessary) is that when you save a post as a draft that is part of the series - the total parts in the series won't be updated until that post is published. This is so that the published series posts will be displayed correctly to blog readers.

Posted 3 years ago #
scompt
Member

Hi Darren,

I'm getting this problem with future posts also. The future post shows up in the post-list toc on the single post page. Also, the count is incorrect ("This entry is part 3 of 2 in ..."). This is when logged out. The future post doesn't show up on the series archive page, but the numbering is still incorrect.

My future post has been moved to position 2 in the series, which is why the numbering is incorrect, I think.

Cheers,
Edward

Posted 3 years ago #
Darren
Neurotic Guy

Thanks for confirming and clarifying this bug scompt. I'll work on it as soon as I get time (which has been in short supply lately).

Posted 3 years ago #
Anonymous
Unregistered

I'm also seeing this problem. Scheduled posts lose their association with a series as soon as they are published. Ouch! Is there a fix available or any insight into why this happens? Thanks!

Posted 3 years ago #
Darren
Neurotic Guy

I'm investigating this as I work on updating OrgSeries for WordPress 2.6

Posted 3 years ago #
Anonymous
Unregistered

I think I've isolated where it's happening, in function wp_set_post_series but not sure why.

Looks to be that the series id is getting lost here and then wp_delete_post_series_relationship is called. Though I'm not sure why this happens upon publish_post because the filter appears to be commented out in series_taxonomy.php:

/**
* add_action() and add_filter() calls go here.
*/
//add_action('edit_post','wp_set_post_series');
//add_action('publish_post','wp_set_post_series');
add_action('save_post','wp_set_post_series');
add_action('delete_post','wp_delete_post_series_relationship');

Should the $series_part in wp_set_post_series be retrieved differently than from $_POST when a post's schedule status is changed to published?

Posted 3 years ago #
Darren
Neurotic Guy

I think you're onto it roundabout, thanks :) saves some time!

Posted 3 years ago #
Anonymous
Unregistered

This seems to work for me, though I don't know if it's the optimal solution. Trying it out tonight in production so we'll see!

function wp_set_post_series( $post_ID = 0, $series_id = 0) { $post_ID = (int) $post_ID;
if ( $series_id == 0 ) { $post_series = (int) $_POST['post_series']; // Account for when the post is getting published on a schedule. if ($post_series == 0) { $series = wp_get_post_series($post_ID); if (!empty($series) ) { $post_series = (int) $series[0]; } } }

Posted 3 years ago #
Anonymous
Unregistered

Back to the drawing board. The previous change doesn't fix the problem. It works if you don't have anything scheduled to be published after the post that is getting published, but if you have subsequent posts scheduled, the post that gets published gets its series reset to be after others that are scheduled, breaking the series order. Arg.

Posted 3 years ago #
Anonymous
Unregistered

Perhaps it would be OK to guarantee that the function short circuits if there is not POST from the form?

function wp_set_post_series( $post_ID = 0, $series_id = 0) {
if ($series_id == 0 && !isset($_POST['post_series']) && !isset($_POST['series_part']))
return FALSE;

Posted 3 years ago #
Darren
Neurotic Guy

Just wanted to quickly post a thanks for your efforts in trying to come up with a fix for this. Wish I could contribute more but I'm just too swamped at work right now. If you want to keep trying go for it - if you come up with a fix I'll be sure to give you credit!

Posted 3 years ago #

Anonymous
Unregistered

I had to work around this recently myself. Here's my solution:

There is a file in the plugin called "series-utility.php". There's a section around line 250 that looks like this:

foreach ($posts as $spost) {
    if (array_key_exists('object_id', $posts)) {
        $spost_id = $spost['object_id'];
    } else {
        $spost_id = $spost;
    }

    if ($skip && $spost_id == $postid) continue;
    $currentpart = get_post_meta($spost_id, SERIES_PART_KEY, true);
    $series_posts[$key]['id'] = $spost_id;
    $series_posts[$key]['part'] = $currentpart;
    $key++;
}

I modified it to check if a post's "post_status" variable is set to "publish" (excluding "draft" and "scheduled" and "private" before adding a post to the list:

foreach ($posts as $spost) {
    if (array_key_exists('object_id', $posts)) {
        $spost_id = $spost['object_id'];
    } else {
        $spost_id = $spost;
    }

    if ($skip && $spost_id == $postid) continue;
    $post = get_post($spost_id);
    if ($post->post_status == "publish") {
        $currentpart = get_post_meta($spost_id, SERIES_PART_KEY, true);
        $series_posts[$key]['id'] = $spost_id;
        $series_posts[$key]['part'] = $currentpart;
        $key++;
    }
}

Posted 3 years ago #

Darren
Neurotic Guy

If nobody reports any problems with this fix I'll add it in to the next version of orgSeries and close this thread. Thanks Chris for your work!

Posted 3 years ago #
Anonymous
Unregistered

I just now realized that my reply up above isn't in the thread I thought it was being posted to. Either that, or I misunderstood the problem in this topic for a different problem I was having.

For the problem where scheduled posts lose their series upon being auto-published, my code snippit is not a solution to that problem. I've only recently discovered the problem in this thread does indeed affect my blog as well.

Posted 3 years ago #
Darren
Neurotic Guy

Not sure if 2.0.8beta fixes this problem but if someone could give it a try and let me know that'd be great ;)! If it <u>doesn't</u> fix the problem then I'll try to get it fixed for the full release of 2.0.8.

Posted 3 years ago #

RSS feed for this topic